[vlc-devel] RE : [PATCH] -- core(update.c) : correct object release misplaced and memory leaks

[Rafaël Carré]

On Mon, 3 Aug 2009 14:39:19 +0200
"brezhoneg1" <brezhoneg1 at yahoo.fr> wrote:

> Is there a real need to release the object as soon as the thread is
> about to end ? If not released right away, it ends up being released
> later on either
>    - when a new download is called

Usually there is only one download

>    - when update_Delete is called
> 
> So I don't think there is a memory leak.

Ah that makes sense, if the object isn't destroyed libvlc will complain
at exit anyway so it's easy to see

> Also, in your case, the assertion failed means the vlc_thread_join has
> never occurred, which may not be a crash but at least means another
> memory leak. ... 

I assume vlc_thread_join is not needed since the thread returns, but
there are other problems like courmisch pointed out

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090803/aae0dbbc/attachment.sig>