[vlc-devel] commit: Have (and document) libvlc_media_get_duration return ms ( Olivier Aubert )

Olivier Aubert olivier.aubert at liris.cnrs.fr
Tue Aug 4 18:59:30 CEST 2009


A remark about this commit: it implicitly breaks the API, as it now
returns media duration in ms while it was previously unspecified in the
doc, and in fact returned microseconds.

However, I do not think that anyone ever used this method (I just did
because I was randomly testing the python bindings), or they would have
asked for the rationale of returning microseconds for this method only,
while all others return milliseconds.

Do you think it is necessary to bump up the API number? There is indeed
an incompatibility introduced here, but maybe a simple notice will be
enough here.

Olivier

On Tue, 2009-08-04 at 17:17 +0200, git version control wrote:
> vlc | branch: master | Olivier Aubert <olivier.aubert at liris.cnrs.fr> | Tue Aug  4 16:53:42 2009 +0200| [bb830b765ee9acad66884c6f23f908b2cafef252] | committer: Olivier Aubert 
> 
> Have (and document) libvlc_media_get_duration return ms
> 
> in order to be consistent with other libvlc methods (libvlc_media_player_get_length, get_time, ...)
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=bb830b765ee9acad66884c6f23f908b2cafef252





More information about the vlc-devel mailing list