[vlc-devel] [PATCH] Added a new play-and-pause option.

[Laurent Aimar]

Hi,

On Tue, Aug 04, 2009, Rémi Denis-Courmont wrote:
> Le mercredi 29 juillet 2009 14:43:00 Elliot Murphy, vous avez écrit :
> > I apologize, it looks like I forgot to include one of the files at
> > first. Sorry, my first time using git. The other patch file is
> > attached now.
> 
> If I understand right, this tries to pause the current item when EOS occurs.
> This will fail if the access/access_demux plugin is incapable of pausing. I am 
> also worried that not all access and access_demux plugins handle 
> SET_PAUSE_STATE properly *after* they returned EOF/EOS (I might be too 
> pessimistic).
 It's not a problem because in this case, the timeshift done by es_out should
kick in (if the access/demux fails) and do the pause (even there won't be any
real timeshift involved as we're at eof).

> Is there any reason why you do this at the end of the input loop, rather than 
> between items within playlist?
(play-and-stop is probably what you are suggesting I think)

 I think the main reasons are:
 - it will allow keeping the last displayed frame (otherwise the vout is flushed
 before terminating the input, even if reused).
 - it allows to seek in the current file/stream and to resume play.

-- 
fenrir