[vlc-devel] commit: Simplify shout, libproxy detection (Jean-Baptiste Kempf )

[git version control]

vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Wed Aug  5 17:15:45 2009 +0200| [30f9eb499bf5e47a05e6652126fc9c4cbec34e11] | committer: Jean-Baptiste Kempf 

Simplify shout, libproxy detection

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=30f9eb499bf5e47a05e6652126fc9c4cbec34e11
---

 configure.ac   |   27 +++------------------------
 m4/with_pkg.m4 |    2 +-
 2 files changed, 4 insertions(+), 25 deletions(-)

diff --git a/configure.ac b/configure.ac
index 8cd5233..058efdb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1702,16 +1702,7 @@ AS_IF([test "${enable_sout}" != "no"], [
 AM_CONDITIONAL(ENABLE_SOUT, [test "${enable_sout}" != "no"])
 
 dnl Check for libshout
-AC_ARG_ENABLE(shout,
-  [  --enable-shout          libshout output plugin (default disabled)])
-if test "${enable_shout}" = "yes"; then
-  PKG_CHECK_MODULES(SHOUT, shout >= 2.1,
-    [AC_DEFINE(HAVE_SHOUT, 1, [Define if you have the libshout library])
-     VLC_ADD_PLUGIN([access_output_shout])
-     VLC_ADD_LIBS([access_output_shout],[$SHOUT_LIBS])
-     VLC_ADD_CFLAGS([access_output_shout],[$SHOUT_CFLAGS])],
-    [AC_MSG_WARN(libshout library not found)])
-fi
+PKG_ENABLE_MODULES_VLC([access_output_shout], [shout >= 2.1], [libshout output plugin], [auto])
 
 dnl Lua modules
 AC_ARG_ENABLE(lua,
@@ -1766,19 +1757,8 @@ AM_CONDITIONAL(BUILD_HTTPD, [test "${enable_httpd}" != "no"])
 dnl
 dnl libproxy support
 dnl
-AC_ARG_ENABLE(libproxy,
-  [  --enable-libproxy       libproxy support (default auto)])
-AS_IF([test "${enable_libproxy}" != "no"], [
-  PKG_CHECK_MODULES(LIBPROXY, libproxy-1.0, [
-    AC_DEFINE(HAVE_LIBPROXY, 1, [Define if libproxy is available])
-    VLC_ADD_CFLAGS([access_http],[$LIBPROXY_CFLAGS])
-    VLC_ADD_LIBS([access_http],[$LIBPROXY_LIBS])
-  ], [
-    AS_IF([test "x${enable_libproxy}" != "x"], [
-      AC_MSG_ERROR([libproxy could not be found on your system])
-    ])
-  ])
-])
+PKG_ENABLE_MODULES_VLC([LIBPROXY], [libproxy-1.0], [libproxy support], [auto])
+
 
 dnl
 dnl VideoLAN manager
@@ -1852,7 +1832,6 @@ AC_ARG_ENABLE(taglib,
       [AC_MSG_WARN(TagLib library not found)])
   ])
 
-
 dnl
 dnl  Input plugins
 dnl
diff --git a/m4/with_pkg.m4 b/m4/with_pkg.m4
index 23a7525..73854e2 100644
--- a/m4/with_pkg.m4
+++ b/m4/with_pkg.m4
@@ -82,7 +82,7 @@ AC_DEFUN([PKG_ENABLE_MODULES_VLC],
 [
 PKG_WITH_MODULES([$1],[$2],
     VLC_ADD_PLUGIN(m4_tolower([$1]))
-    VLC_ADD_CFLAGS(m4_tolower([$1]),[$$1_CFLAGS] [$5] )
+    VLC_ADD_CFLAGS(m4_tolower([$1]),[$$1_CFLAGS] [$5])
     VLC_ADD_LIBS(m4_tolower([$1]),[$$1_LIBS] [$6]),
     AS_IF([test x"$AS_TR_SH([enable_]m4_tolower([$1]))" = "xyes"],
         [AC_MSG_ERROR(Library [$2] needed for [m4_tolower([$1]) was not found])],