[vlc-devel] [PATCH] Qt4 playlist: fix segfault and other enhancements

[Jakob Leben]

2009/8/11 Rémi Denis-Courmont <remi at remlab.net>

> I don't think playlist_Add actually copies an input item. I assume this
> looses
> the input item options.
>

The idea was that draging items from playlist to media library and vice
versa does exactly the same action as adding those items via the add action
of the playlist dialog.
Do you have reservations against that?

I know that currently there is a problem with "copying" items by uri: when
you add a directory with subdirectories to a playlist, then the subdirectory
items in tree mode get vlc://nop uri instead of their real uri. Moreover,
when saving playlist to xspf format and loading it back, all the node items
get their uris substituted by vlc://nop. So when "copying" such an item and
trying to play it, it will not be expanded again into a node and filled with
sub-items as expected.

All of this has to do with xspf saving and demuxing. I'm working on
correcting that too, but the code in this patch will stay and will be
completely usable and functioning correctly after modifying xspf behavior.

Of course it is open for discussion whether it is desirable to have that
copy behavior. But in my opinion the current behavior is just absurd: why
would you wanna *move* an item from media library into playlist?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090812/c0e227e5/attachment.html>