[vlc-devel] commit: threads: simplify (Pierre Ynard )

git version control git at videolan.org
Wed Aug 12 16:48:29 CEST 2009


vlc | branch: master | Pierre Ynard <linkfanel at yahoo.fr> | Wed Aug 12 16:44:51 2009 +0200| [bce03d65055607ec039040c8ceba9cb7511dd091] | committer: Pierre Ynard 

threads: simplify

Remove repeated code

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=bce03d65055607ec039040c8ceba9cb7511dd091
---

 src/misc/threads.c |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/misc/threads.c b/src/misc/threads.c
index 005a0ff..0341747 100644
--- a/src/misc/threads.c
+++ b/src/misc/threads.c
@@ -166,10 +166,7 @@ void __vlc_thread_join( vlc_object_t *p_this )
 {
     vlc_object_internals_t *p_priv = vlc_internals( p_this );
 
-#if defined( LIBVLC_USE_PTHREAD )
-    vlc_join (p_priv->thread_id, NULL);
-
-#elif defined( WIN32 ) && !defined( UNDER_CE )
+#if defined( WIN32 ) && !defined( UNDER_CE )
     HANDLE hThread;
     FILETIME create_ft, exit_ft, kernel_ft, user_ft;
     int64_t real_time, kernel_time, user_time;
@@ -185,9 +182,11 @@ void __vlc_thread_join( vlc_object_t *p_this )
         p_priv->b_thread = false;
         return; /* We have a problem! */
     }
+#endif
 
     vlc_join( p_priv->thread_id, NULL );
 
+#if defined( WIN32 ) && !defined( UNDER_CE )
     /* FIXME: this could work on WinCE too... except that it seems always to
      * return 0 for exit_ft and kernel_ft */
     if( GetThreadTimes( hThread, &create_ft, &exit_ft, &kernel_ft, &user_ft ) )
@@ -215,10 +214,6 @@ void __vlc_thread_join( vlc_object_t *p_this )
                  (double)((user_time%(60*1000000))/1000000.0) );
     }
     CloseHandle( hThread );
-
-#else
-    vlc_join( p_priv->thread_id, NULL );
-
 #endif
 
     p_priv->b_thread = false;




More information about the vlc-devel mailing list