[vlc-devel] Help
Sofia Kunin - Rosslare Security
sofia.kunin at rosslaresecurity.com
Thu Aug 13 16:57:38 CEST 2009
Hello,
Unsubscribe me from vlc-devel Digest. I don't want to receive your e-mails.
Best Regards,
Sofia Kunin
Software Developer R&D
(+972-4-9590693
www.rosslaresecurity.com
-----Original Message-----
From: vlc-devel-bounces at videolan.org [mailto:vlc-devel-bounces at videolan.org]
On Behalf Of vlc-devel-request at videolan.org
Sent: Thursday, August 13, 2009 3:58 PM
To: vlc-devel at videolan.org
Subject: vlc-devel Digest, Vol 27, Issue 77
Send vlc-devel mailing list submissions to
vlc-devel at videolan.org
To subscribe or unsubscribe via the World Wide Web, visit
http://mailman.videolan.org/listinfo/vlc-devel
or, via email, send a message with subject or body 'help' to
vlc-devel-request at videolan.org
You can reach the person managing the list at
vlc-devel-owner at videolan.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of vlc-devel digest..."
Today's Topics:
1. commit: Qt4: add mutex-lockin when accessing selector-names
(Ilkka Ollakka ) (git version control)
2. Re: commit: Qt4: store input_item_t* in plitem and handle
metadata in model ( Ilkka Ollakka ) (Jakob Leben)
3. Re: commit: Qt4: store input_item_t* in plitem and handle
metadata in model ( Ilkka Ollakka ) (Ilkka Ollakka)
4. commit: Qt4: typo in playlist_item (Ilkka Ollakka )
(git version control)
5. Re: commit: Qt4: store input_item_t* in plitem and handle
metadata in model ( Ilkka Ollakka ) (Jakob Leben)
6. Re: commit: Added support for AOB files (LPCM/MLP) to our PS
demuxer. ( Laurent Aimar ) (jpd at videolan.org)
7. Re: Announce: brand new python bindings (ctypes-based)
(jpd at videolan.org)
8. Re: commit: Qt4: store input_item_t* in plitem and handle
metadata in model ( Ilkka Ollakka ) (Jakob Leben)
----------------------------------------------------------------------
Message: 1
Date: Thu, 13 Aug 2009 15:14:20 +0200 (CEST)
From: git at videolan.org (git version control)
Subject: [vlc-devel] commit: Qt4: add mutex-lockin when accessing
selector-names (Ilkka Ollakka )
To: vlc-devel at videolan.org
Message-ID: <20090813131420.8EFF527C808 at skanda.videolan.org>
Content-Type: text/plain; charset=UTF-8
vlc | branch: master | Ilkka Ollakka <ileoo at videolan.org> | Thu Aug 13
16:10:12 2009 +0300| [96b97b1612e584d4e0c24a884c1333f2e52abe8a] | committer:
Ilkka Ollakka
Qt4: add mutex-lockin when accessing selector-names
>
http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=96b97b1612e584d4e0c24
a884c1333f2e52abe8a
---
.../gui/qt4/components/playlist/playlist_model.cpp | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/modules/gui/qt4/components/playlist/playlist_model.cpp
b/modules/gui/qt4/components/playlist/playlist_model.cpp
index c6fc9a4..d60c078 100644
--- a/modules/gui/qt4/components/playlist/playlist_model.cpp
+++ b/modules/gui/qt4/components/playlist/playlist_model.cpp
@@ -322,7 +322,12 @@ QVariant PLModel::data( const QModelIndex &index, int
role ) const
int metadata = 1;
if( item->model->i_depth == DEPTH_SEL )
- return QVariant( QString( qfu( item->p_input->psz_name ) ) );
+ {
+ vlc_mutex_lock( &item->p_input->lock );
+ QString returninfo = QString( qfu( item->p_input->psz_name ) );
+ vlc_mutex_unlock( &item->p_input->lock );
+ return QVariant(returninfo);
+ }
while( metadata < COLUMN_END )
{
------------------------------
Message: 2
Date: Thu, 13 Aug 2009 15:47:10 +0200
From: Jakob Leben <jakob.leben at gmail.com>
Subject: Re: [vlc-devel] commit: Qt4: store input_item_t* in plitem
and handle metadata in model ( Ilkka Ollakka )
To: Mailing list for VLC media player developers
<vlc-devel at videolan.org>
Message-ID:
<a6283adc0908130647l7aacf654pbe1698c6b5680ef7 at mail.gmail.com>
Content-Type: text/plain; charset="iso-8859-1"
On Thu, Aug 13, 2009 at 2:48 PM, git version control
<git at videolan.org>wrote:
> diff --git a/modules/gui/qt4/components/playlist/playlist_item.cpp
> b/modules/gui/qt4/components/playlist/playlist_item.cpp
> index b0436f0..4b54806 100644
> --- a/modules/gui/qt4/components/playlist/playlist_item.cpp
> +++ b/modules/gui/qt4/components/playlist/playlist_item.cpp
> @@ -48,15 +48,17 @@
> */
>
>
> -void PLItem::init( int _i_id, int _i_input_id, bool _is_node, PLItem
> *parent, PLModel *m, QSettings *settings )
> +void PLItem::init( playlist_item_t *_playlist_item, PLItem *parent,
> PLModel *m, QSettings *settings )
> {
> parentItem = parent; /* Can be NULL, but only for the
rootItem
> */
> - i_id = _i_id; /* Playlist item specific id */
> - i_input_id = _i_input_id; /* Identifier of the input */
> + i_id = _playlist_item->i_id; /* Playlist item
specific
> id */
> + i_input_id = _playlist_item->p_input->i_id; /* Identifier of the
> input */
> model = m; /* PLModel (QAbsmodel) */
> i_type = -1; /* Item type - Avoid segfault */
> b_current = false; /* Is the item the current Item or not
*/
> - b_is_node = _is_node;
> *+ b_is_node = _playlist_item->i_children > 1;*
> + p_input = _playlist_item->p_input;
> + vlc_gc_incref( p_input );
>
Should be:
b_is_node = _playlist_item->i_children > - 1;
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090813/4760f1
d1/attachment-0001.htm>
------------------------------
Message: 3
Date: Thu, 13 Aug 2009 16:51:07 +0300
From: Ilkka Ollakka <ilkka.ollakka+vlc at oamk.fi>
Subject: Re: [vlc-devel] commit: Qt4: store input_item_t* in plitem
and handle metadata in model ( Ilkka Ollakka )
To: Mailing list for VLC media player developers
<vlc-devel at videolan.org>
Message-ID: <20090813135107.GA30135 at papu.site>
Content-Type: text/plain; charset="us-ascii"
On to 13. elokuuta 2009 15.47.10, Jakob Leben wrote:
>
> Should be:
> b_is_node = _playlist_item->i_children > - 1;
ah yes it should.
--
Ilkka Ollakka
Others will look to you for stability, so hide when you bite your
nails.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090813/9ffb88
0f/attachment-0001.pgp>
------------------------------
Message: 4
Date: Thu, 13 Aug 2009 15:51:59 +0200 (CEST)
From: git at videolan.org (git version control)
Subject: [vlc-devel] commit: Qt4: typo in playlist_item (Ilkka Ollakka
)
To: vlc-devel at videolan.org
Message-ID: <20090813135159.3135927CDBF at skanda.videolan.org>
Content-Type: text/plain; charset=UTF-8
vlc | branch: master | Ilkka Ollakka <ileoo at videolan.org> | Thu Aug 13
16:51:42 2009 +0300| [3ecb268ccbcfdafaa7d8dc8f81571d5e88a18cf8] | committer:
Ilkka Ollakka
Qt4: typo in playlist_item
>
http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3ecb268ccbcfdafaa7d8d
c8f81571d5e88a18cf8
---
.../gui/qt4/components/playlist/playlist_item.cpp | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/modules/gui/qt4/components/playlist/playlist_item.cpp
b/modules/gui/qt4/components/playlist/playlist_item.cpp
index 4b54806..f9e3b8a 100644
--- a/modules/gui/qt4/components/playlist/playlist_item.cpp
+++ b/modules/gui/qt4/components/playlist/playlist_item.cpp
@@ -56,7 +56,7 @@ void PLItem::init( playlist_item_t *_playlist_item, PLItem
*parent, PLModel *m,
model = m; /* PLModel (QAbsmodel) */
i_type = -1; /* Item type - Avoid segfault */
b_current = false; /* Is the item the current Item or not */
- b_is_node = _playlist_item->i_children > 1;
+ b_is_node = _playlist_item->i_children > -1;
p_input = _playlist_item->p_input;
vlc_gc_incref( p_input );
------------------------------
Message: 5
Date: Thu, 13 Aug 2009 15:54:24 +0200
From: Jakob Leben <jakob.leben at gmail.com>
Subject: Re: [vlc-devel] commit: Qt4: store input_item_t* in plitem
and handle metadata in model ( Ilkka Ollakka )
To: Mailing list for VLC media player developers
<vlc-devel at videolan.org>
Message-ID:
<a6283adc0908130654t3888d089pcbc48acc29f26caf at mail.gmail.com>
Content-Type: text/plain; charset="iso-8859-1"
On Thu, Aug 13, 2009 at 2:48 PM, git version control
<git at videolan.org>wrote:
> Hopefully
> that vlc_gc_incref/vlc_gc_decref is sufficient for that input_item_t
> pointer protection.
>
I see vlc_gc_incref in the patch, but I don't see vlc_gc_decref anywhere. I
guess it should be called in ~PLItem();
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090813/35cbb7
eb/attachment-0001.htm>
------------------------------
Message: 6
Date: Thu, 13 Aug 2009 15:55:18 +0200
From: jpd at videolan.org
Subject: Re: [vlc-devel] commit: Added support for AOB files
(LPCM/MLP) to our PS demuxer. ( Laurent Aimar )
To: Mailing list for VLC media player developers
<vlc-devel at videolan.org>
Message-ID: <20090813135518.GA28213 at www.m2x.eu>
Content-Type: text/plain; charset=us-ascii
On Fri, Aug 07, 2009 at 08:53:54PM +0200, git version control wrote:
> vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Fri Aug 7
19:56:14 2009 +0200| [deeb97576811b4d4220d31a3389165da026695f0] | committer:
Laurent Aimar
[snip]
> +#define PS_TK_COUNT (256+256+256+8 - 0xc0)
> +#if 0
> #define PS_ID_TO_TK( id ) ((id) <= 0xff ? (id) - 0xc0 : \
> ((id)&0xff) + (((id)&0xff00) == 0xbd00 ? 256-0xC0 : 512-0xc0)
)
> +#else
> +static inline int ps_id_to_tk( unsigned i_id )
> +{
> + if( i_id <= 0xff )
> + return i_id - 0xc0;
> + else if( (i_id & 0xff00) == 0xbd00 )
> + return 256-0xC0 + (i_id & 0xff);
> + else if( (i_id & 0xff00) == 0xfd00 )
> + return 512-0xc0 + (i_id & 0xff);
> + else
> + return 768-0xc0 + (i_id & 0x07);
> +}
> +#define PS_ID_TO_TK( id ) ps_id_to_tk( id )
> +#endif
I've been meaning to look at this because it looks a prime candidate
for a switch() instead of some stacked if() statements. But, the input
seems to come from a uint8_t *, so I'm wondering whether this isn't
essentially dead code anyhow.
Could someone clarify this please?
------------------------------
Message: 7
Date: Thu, 13 Aug 2009 15:55:56 +0200
From: jpd at videolan.org
Subject: Re: [vlc-devel] Announce: brand new python bindings
(ctypes-based)
To: Mailing list for VLC media player developers
<vlc-devel at videolan.org>
Message-ID: <20090813135556.GB28213 at www.m2x.eu>
Content-Type: text/plain; charset=us-ascii
On Fri, Jul 31, 2009 at 01:38:16PM +0200, Olivier Aubert wrote:
> The compromise "for all functions that cannot return with an error" is
> however not that easy to sort out. How can you be sure that a function
> cannot return with an error? And anyway, if this was adopted, it would
> be necessary (from the bindings generation POV) to clearly indicate in
> prototypes the behaviour.
Yes, that's true, but doable. There are a few functions that upon
inspection turn out to not do anything at all with the exception passed
and then they can be converted. I expect this to be a rather small class
of mainly accessors, of the kind that ought to be static inline anyway.
Speaking of which, there are a few of those and I suspect you have to
special-case those for the python bindings in any case.
------------------------------
Message: 8
Date: Thu, 13 Aug 2009 15:58:08 +0200
From: Jakob Leben <jakob.leben at gmail.com>
Subject: Re: [vlc-devel] commit: Qt4: store input_item_t* in plitem
and handle metadata in model ( Ilkka Ollakka )
To: Mailing list for VLC media player developers
<vlc-devel at videolan.org>
Message-ID:
<a6283adc0908130658oe32f6dge93e3029e4b3d72c at mail.gmail.com>
Content-Type: text/plain; charset="iso-8859-1"
On Thu, Aug 13, 2009 at 2:48 PM, git version control
<git at videolan.org>wrote:
> -void PLItem::init( int _i_id, int _i_input_id, bool _is_node, PLItem
> *parent, PLModel *m, QSettings *settings )
> +void PLItem::init( playlist_item_t *_playlist_item, PLItem *parent,
> PLModel *m, QSettings *settings )
>
Also, now you are not only counting on input item pointer to be valid, but
also on playlist item pointer. Are you sure that PLItem functions like this
are always called within PL_LOCK? At least it should be documented that
PL_LOCK must be held upon entering the function!
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090813/4f134b
dd/attachment.htm>
------------------------------
_______________________________________________
vlc-devel mailing list
vlc-devel at videolan.org
http://mailman.videolan.org/listinfo/vlc-devel
End of vlc-devel Digest, Vol 27, Issue 77
*****************************************
More information about the vlc-devel
mailing list