[vlc-devel] [RFC] [PATCH 0/2] Xlib removal

Rémi Denis-Courmont remi at remlab.net
Sun Aug 16 22:36:58 CEST 2009


	Hello,

I am not aware of any remaining "fundamental" design issue with the XCB X11 & XVideo display plugins. There are 
some missing pieces, but I don't expect any particular controversy in their implementing:
- automatic cursor hiding,
- XVideo port grabbing,
- XVideo chroma keying (if we still need this...?),
- DPMS (same question)
Overall, it those plugins should be good enough for testing anyway, so I increased their priority to normal 
values.

Now comes the question what to do with the existing Xlib video outputs. I have no intentions to port them to the 
new video display module API, as I consider Xlib to be fundamentally flawed for threaded programs (such as VLC). 
On top of that, X.Org has ported the Xlib back-end from the crappy old Xtrans to XCB a while ago, such that 
practically all non-antique distro have XCB anyway. In the worst case, we could add XCB to contribs (it's quite 
small). This far, I have not seen any complaints on the dependency of VLC 1.0 globalhotkeys onto XCB.

On the other hand, the Xlib dependency is not going away any time soon. The skins interface and the XvMC output 
have not been ported to XCB. I don't use either of them, so I'm not a good candidate for that job. Most 
importantly, the GLX OpenGL provider is fundamentally dependent on Xlib, as the GLX standard API is designed 
around Xlib. Also, Qt4-X11 uses Xlib internally.

 modules/video_output/x11/Modules.am |   12 -
 modules/video_output/x11/x11.c      |   67 -----
 modules/video_output/x11/xcommon.c  |  424 ------------------------------------
 modules/video_output/x11/xcommon.h  |   15 -
 modules/video_output/x11/xvideo.c   |  122 ----------
(Note: configure.ac changes not included)
 
-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list