[vlc-devel] [PATCH] Solve a pause behaviour problem in fake access/demux
hugo at vlmc.org
Mon Aug 17 07:52:09 CEST 2009
2009/7/30 Rémi Denis-Courmont <remi at remlab.net>:
> Le jeudi 30 juillet 2009 15:13:25 Hugo Beauzee-Luyssen, vous avez écrit :
>> There's a potential error source inside of the fake access/demux :
>> When the media player is paused, the `Control` function stores the
>> current pts, and uses it to compute the pause duration.
>> If using --no-skip-frames, this can be a problem, making the pause
>> twice as long as intended. This patch corrects it.
> config_GetInt() is wrong, as the input item might override the configuration
> value. var_CreateGetInteger() would be wrong, as it would create a new
> variable, hence preventing a later change of the variable on the input item
> from propagating. var_GetInteger() would not work as the variable does not
> exist on the demux object.
> So... I'm afraid accessing the skip-frame variable that way cannot work
> properly. Maybe the logic should be entirely rewritten??
By "the logic", do you mean the entire no-skip-frames logic ? or just
the demux logic ?
In either case, I don't feel good in fixing it :p
Should I let it to the VLC team ? I guess this is not what may be
called a priority, however, we do need it in vlmc to be able to pause
Any advice or direction is welcome !
More information about the vlc-devel