[vlc-devel] commit: qt4: remove b_is_node and use childCount() > 0 instead in playlist_model (Ilkka Ollakka )

Ilkka Ollakka ilkka.ollakka+vlc at oamk.fi
Mon Aug 17 22:18:37 CEST 2009

On ma 17. elokuuta 2009 21.52.38, Jakob Leben wrote:
> This commit is wrong: playlist_item_t->i_children > -1 is not equal to
> childCount() > 0!
> The former tells us if the item is of node type or not. But an item can be
> node and still have i_children == 0, hence childCount() == 0! And vice
> versa, a PLItem can have childCount() == 0, but not be a node!
 Is there any real cases where it matters? eg why would there be
 significant nodes in playlist that has to show as nodes even if it's
 empty ?

Ilkka Ollakka
So, what's with this guy Gideon, anyway?  And why can't he ever
remember his Bible?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090817/5cd84c3b/attachment.sig>

More information about the vlc-devel mailing list