[vlc-devel] commit: qt4: remove b_is_node and use childCount() > 0 instead in playlist_model (Ilkka Ollakka )

Ilkka Ollakka ilkka.ollakka+vlc at oamk.fi
Mon Aug 17 23:33:06 CEST 2009

On ma 17. elokuuta 2009 22.31.19, Jakob Leben wrote:
> This triggers a bigger issue: why is it possible to delete children of nodes
> when it has no sense for a node to be empty?
> But the point right now is that it is possible to empty a node and maybe you
> want to fill it later again. Refilling it will not be possible as the node
> will not be Qt::ItemIsDropEnabled anymore.
 I don't actually use tree-mode of playlist allmost ever, so I don't
 really have that strong opinion on thisone. But why wouldn't you be
 allowed to drop items on normal leaf making it node? I know that
 currently they represent directory-stucture prettymuch (and on
 shoutcast category-structure), but if they're just tree with freedom to
 move stuff around, what would it cause that would be non-trivial to
 handle or odd for user in UI.

 I didn't check current playlist-code if it allows thatkinda random
 adding childrens on any nodes. And I have no idea how users use
 tree-mode currently.

> If you want to keep current implementation then we might just as well
> disable deleting children of nodes. But I suggest we look forward to a day
> when it will be possible to create arbitrary nodes with preffered names and
> add/remove items to them at will.

 I don't actually see any reason why you couldn't crete those nodes even
 now (only menu-selection is missing on context-menu and few lines of
 code, maybe).

Ilkka Ollakka
It's raisins that make Post Raisin Bran so raisiny ...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090818/e8e861fc/attachment.sig>

More information about the vlc-devel mailing list