[vlc-devel] commit: utf8_open: make third parameter optional ( Rémi Denis-Courmont )

Rafaël Carré rafael.carre at gmail.com
Tue Aug 18 15:00:56 CEST 2009


On Tue, 18 Aug 2009 08:50:59 +0200
Rémi Denis-Courmont <remi at remlab.net> wrote:

> 
> On Tue, 18 Aug 2009 05:52:14 +0200, Rafaël Carré
> <rafael.carre at gmail.com> wrote:
> > This breaks (SIGILL) on windows XP 32 bits as reported by Trax, my
> FreeBSD
> > 8 (64 bits), OSX (jones); but not on Linux (i used
> > valgrind/memcheck to catch anything obvious)
> 
> -        mode = va_arg (ap, mode_t);
> +        mode = va_arg (ap, unsigned);
> 

This fixes the problem on jones, sizeof(mode_t) == 2 and
sizeof(unsigned) == 4, while on my linux sizeof(mode_t) ==
sizeof(unsigned) == 4.

Would it look nicer to cast 3rd argument to mode_t or to use this patch?

I let you commit it ^^

thanks

-- 
Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090818/935c29a6/attachment.sig>


More information about the vlc-devel mailing list