[vlc-devel] commit: Remove filter_chain_GetFilter: unused and not thread-safe ( Rémi Denis-Courmont )

git version control git at videolan.org
Wed Aug 19 23:05:46 CEST 2009


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Aug 19 23:44:57 2009 +0300| [0b5502c3d8bf855bc8ea4352d079a6cfe5844b59] | committer: Rémi Denis-Courmont 

Remove filter_chain_GetFilter: unused and not thread-safe

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0b5502c3d8bf855bc8ea4352d079a6cfe5844b59
---

 include/vlc_filter.h    |   10 ----------
 src/libvlccore.sym      |    1 -
 src/misc/filter_chain.c |   31 -------------------------------
 3 files changed, 0 insertions(+), 42 deletions(-)

diff --git a/include/vlc_filter.h b/include/vlc_filter.h
index 9ec2217..cd7943a 100644
--- a/include/vlc_filter.h
+++ b/include/vlc_filter.h
@@ -300,16 +300,6 @@ VLC_EXPORT( int, filter_chain_AppendFromString, ( filter_chain_t *, const char *
 VLC_EXPORT( int, filter_chain_DeleteFilter, ( filter_chain_t *, filter_t * ) );
 
 /**
- * Get filter by name of position in the filter chain.
- *
- * \param p_chain pointer to filter chain
- * \param i_position position of filter in filter chain
- * \param psz_name name of filter to get
- * \return filter object based on position or name provided
- */
-VLC_EXPORT( filter_t *, filter_chain_GetFilter, ( filter_chain_t *, int, const char * ) );
-
-/**
  * Get the number of filters in the filter chain.
  *
  * \param p_chain pointer to filter chain
diff --git a/src/libvlccore.sym b/src/libvlccore.sym
index 6381f5d..d98396a 100644
--- a/src/libvlccore.sym
+++ b/src/libvlccore.sym
@@ -124,7 +124,6 @@ filter_chain_AppendFromString
 filter_chain_AudioFilter
 filter_chain_Delete
 filter_chain_DeleteFilter
-filter_chain_GetFilter
 filter_chain_GetFmtOut
 filter_chain_GetLength
 filter_chain_MouseFilter
diff --git a/src/misc/filter_chain.c b/src/misc/filter_chain.c
index e470bef..255a25e 100644
--- a/src/misc/filter_chain.c
+++ b/src/misc/filter_chain.c
@@ -201,37 +201,6 @@ int filter_chain_DeleteFilter( filter_chain_t *p_chain, filter_t *p_filter )
     return UpdateBufferFunctions( p_chain );
 }
 
-/**
- * Reading from the filter chain
- */
-filter_t *filter_chain_GetFilter( filter_chain_t *p_chain, int i_position,
-                                  const char *psz_name )
-{
-    if( psz_name )
-    {
-        if( i_position < 0 )
-            return NULL;
-
-        for( int i = 0; i < vlc_array_count( &p_chain->filters ); i++ )
-        {
-            filter_t *p_filter = vlc_array_item_at_index( &p_chain->filters, i );
-            if( !strcmp( p_filter->psz_object_name, psz_name ) )
-            {
-                if( i_position <= 0 )
-                    return p_filter;
-                i_position--;
-            }
-       }
-        return NULL;
-    }
-    else
-    {
-        if( i_position < 0 || i_position >= vlc_array_count( &p_chain->filters ) )
-            return NULL;
-        return vlc_array_item_at_index( &p_chain->filters, i_position );
-    }
-}
-
 int filter_chain_GetLength( filter_chain_t *p_chain )
 {
     return vlc_array_count( &p_chain->filters );




More information about the vlc-devel mailing list