[vlc-devel] commit: Revert "nuv: Fix some warnings and fix an issue where some unitialized pointer access could lead to a crash ." (Laurent Aimar )
pdherbemont at gmail.com
Mon Aug 24 23:28:40 CEST 2009
On Aug 24, 2009, at 10:43 PM, git version control wrote:
> vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Mon Aug
> 24 22:22:55 2009 +0200| [9ae21742fae1c166888bf32c7f13e898275f678f] |
> committer: Laurent Aimar
> Revert "nuv: Fix some warnings and fix an issue where some
> unitialized pointer access could lead to a crash."
> This reverts commit 3bbe374b28aa3452cc2da64becb3445cf1d20833.
> This commit is wrong. There was no risk of crash. I will add assert
> instead when not obvious.
Well, locally there seems to be a risk of crash are p_seek_table and
p_kfa_table may still be used unitialized. So an assert() is certainly
needed, because there is nothing obvious here. (There still seem to be
a bug here)
More information about the vlc-devel