[vlc-devel] commit: Revert "vout_pictures: Use unsigned for width and height in picture_Export." (Laurent Aimar )

[Laurent Aimar]

On Tue, Aug 25, 2009, Pierre d'Herbemont wrote:
>
> On Aug 24, 2009, at 11:44 PM, Laurent Aimar wrote:
>
>> On Mon, Aug 24, 2009, Pierre d'Herbemont wrote:
>>>
>>> On Aug 24, 2009, at 10:43 PM, git version control wrote:
>>>
>>>> vlc | branch: master | Laurent Aimar <fenrir at videolan.org> | Mon Aug
>>>> 24 22:10:51 2009 +0200| [533ea9d053094332562fa201567810ee9bc63fc2] |
>>>> committer: Laurent Aimar
>>>>
>>>> Revert "vout_pictures: Use unsigned for width and height in
>>>> picture_Export."
>>>>
>>>> This reverts commit 13268071115898a03f9b1d3c470a72de82eabf0c.
>>>>
>>>> It is wrong as -1 and 0 does not have the same meaning for
>>>> picture_Export.
>>>> (I will document it).
>>>
>>> Why would you make a difference? A 0 width picture is certainly not
>>> valid, no?
>> I have documented it in 3c27577ea7dbe53644b4340c6802216c1180e120.
>
> Thanks Laurent!
>
> To me it seems weird to use int here. And this makes me nitpick:
> The -1 value is obscure and probably a bit useless as one can query the 
> picture to get the original dimension.
 Well, it's a bit more complex as you have to apply the aspect ratio.
(And preferably in the same way other part of the vout does it).

> I know this is not public API, so 
> it matters less, yet, do we really want to keep it that way?
 I don't think it would be cleaner to try a all cost to avoid the
int here (and then we would need to break the meaning of the configuration
variables snapshot-width/height or add some code to translate them).

-- 
fenrir