[vlc-devel] [PATCH] - Added input resource support to LibVLC Media Player

[Pierre d'Herbemont]

On Aug 24, 2009, at 10:05 PM, Niles Bindel wrote:

> Hi all,
>
> This patch adds input resource support to the LibVLC Media Player.   
> This change allows for smoother transitioning between playlist items  
> by not having to recreate the related video/audio resources from  
> scratch on every item switch.  This problem was very apparent in  
> fullscreen mode when the current display would close out showing the  
> OS background and then go back to fullscreen before playing the next  
> item.
>
> This is the first of a few patches I will be submitting that will be  
> correcting playlist related issues with the browser plugins.
>
> +
> +    /* Wait until the thread is dead so we can detach the input  
> resource. */
> +    while(!p_input_thread->b_dead)
> +    {
> +        msleep(1000);
> +    }

If I recall well, you should be able to change that to an  
assert(p_input_thread->b_dead), because after vlc_thread_join(input)  
you should always be dead.

The rest of the patch is ok for me!

Thanks!

Pierre.