[vlc-devel] [PATCH] - Added input resource support to LibVLC Media Player

Pierre d'Herbemont pdherbemont at gmail.com
Tue Aug 25 16:52:26 CEST 2009


On Aug 25, 2009, at 4:05 PM, Niles Bindel wrote:

> Ok, I tried moving the detach to after the thread join and it worked  
> as you expected.  I had modeled this after the VLC playlist which  
> did it in that initial order, so I thought that the order might be  
> important.
>
> At this point, should I create another patch with just the removal  
> of the sleep loop or an entirely new patch?

Just a new patch: "git commit -a --amend" or "git rebase -i" is your  
friend.

That makes me think, you don't actually release the p_input_resource  
in libvlc_media_player_release(), this should be addressed as well in  
that same patch.

Thanks!

Pierre.



More information about the vlc-devel mailing list