[vlc-devel] commit: transcode: flag a bug ( Rémi Denis-Courmont )

[Rémi Denis-Courmont]

Le mardi 25 août 2009 18:01:54 git version control, vous avez écrit :
>              while( p_ssys->i_first_pic == i_first_pic )
> -                msleep( 5000 );
> +            {
> +#warning THERE IS A DEFINITELY BUG! LOCKING IS INSUFFICIENT!
> +                msleep( 10000 );
> +                barrier ();
> +            }

msleep() often behaves like a memory barrier, but there are no warranties. 
Also, comparing integers is not an atomic operation; in other words, the 
while() loop condition may be misevaluated.

-- 
Rémi Denis-Courmont
http://www.remlab.net/