[vlc-devel] [PATCH] - Added input resource support to LibVLC Media Player

[Pierre d'Herbemont]

On Aug 25, 2009, at 7:18 PM, Niles Bindel wrote:

> > That makes me think, you don't actually release the  
> p_input_resource in libvlc_media_player_release(), this should be  
> addressed as > well in that same patch.
>
> Good catch.  I've updated the patch to include the aforementioned  
> changes.
>
> Let me know if there are any further issues.


Thanks! Seems like my first review wasn't complete:

> +    assert( p_mi->p_input_resource == NULL );

This assert because it highlight. Yet, how this can work multiple  
time? Should you add
	p_mi->p_input_resource  = NULL
after input_Create()?

> +    assert( p_input_thread->b_dead );
> +    /* Store the input resource for future use. */
> +    p_mi->p_input_resource = input_DetachResource( p_input_thread );

Pierre.