[vlc-devel] [PATCH][GSoC 09]RTMP implementation (Input part)

[Rémi Duraffort]

Hello,
I haven't read the complete patch but I already have two comments:

1/ Never print the password in the log
> +    if( url.psz_username && *url.psz_username )
>      {
> -        msg_Dbg( p_access, "      user='%s'",
>          p_sys->p_thread->url.psz_username );
> +        msg_Dbg( p_access, "      user='%s', pwd='%s'",
> +                 url.psz_username, url.psz_password );
>      }


2/ Could you keep the modifications I did about swfurl and pageurl ?
Or do you have a reason to remove them ?

>      tmp_buffer = amf_encode_object_variable( "swfUrl",
> -         AMF_DATATYPE_STRING, p_thread->psz_swf_url );
> +         AMF_DATATYPE_UNDEFINED, "" );
>      rtmp_body_append( rtmp_body, tmp_buffer,
>          AMF_DATATYPE_SIZE_OBJECT_VARIABLE + strlen( "swfUrl" ) +
> -        AMF_DATATYPE_SIZE_STRING + strlen( p_thread->psz_swf_url ) );
> +        AMF_DATATYPE_SIZE_UNDEFINED );
>      free( tmp_buffer );

and

>      tmp_buffer = amf_encode_object_variable( "pageUrl",
> -        AMF_DATATYPE_STRING, p_thread->psz_page_url );
> +        AMF_DATATYPE_UNDEFINED, "" );
>      rtmp_body_append( rtmp_body, tmp_buffer,
>          AMF_DATATYPE_SIZE_OBJECT_VARIABLE + strlen( "pageUrl" ) +
> -        AMF_DATATYPE_SIZE_STRING + strlen( p_thread->psz_page_url ) );
> +        AMF_DATATYPE_SIZE_UNDEFINED );
>      free( tmp_buffer );


Best regards

-- 
Rémi Duraffort | ivoire