[vlc-devel] commit: Implement access_GetParentInput and demux_GetParentInput and use. ( Pierre d'Herbemont )

Rémi Denis-Courmont remi at remlab.net
Thu Aug 27 08:50:09 CEST 2009

On Wed, 26 Aug 2009 22:27:10 +0200, Pierre d'Herbemont
<pdherbemont at gmail.com> wrote:
> My point is we don't do proper refcounting on some object that  
> announce it.

You still failed to give any concrete example of that.

> Your point is that we've never been annoucing more than only  
> refcounting internals so that variables can be used.

No. The point is that we have not been exposing at least:
- object name,
- object type (name),
- VLC variables,
- children list,
- "alive" status and ability to kill.

> So obviously there is something missing: The documentation on that, or  
> the name changes in the API, to be less misleading.

It is not misleading. It holds an object, not an access/demux/whatever.
You are misleading.

> We don't do proper refcounting for (all?) vlc_object_t, even if we  
> pretend we do by having this vlc_object_hold. (This used to be even  
> more true back in the time when we used to wait until object  
> destruction).

You still failed to give any such object. I am not aware of any error in
our handling of access and demux objects, other than the way we "kill" them
(which is _not_ a reference counting problem anyhow).

vlc_object_hold() is legal if:
- the caller already has a reference to the object, and/or
- the caller has the LibVLC structure lock.

Rémi Denis-Courmont

More information about the vlc-devel mailing list