[vlc-devel] [PATCH] - Added ability to move to previous item in Media List Player, also added playback modes to enable looping and repeating of playlist items.

Pierre d'Herbemont pdherbemont at gmail.com
Thu Aug 27 11:33:11 CEST 2009

On Aug 27, 2009, at 12:32 AM, Niles Bindel wrote:

> <0001-Added-ability-to-move-to-previous-item-in-the-media-.patch>

Hi Niles,

This is a great patch!

Have you considered adding some test code for the new functions? (So  
that it doesn't regress one day) it's in vlc/test/libvlc/.

So the get_next_path stuff was probably the more hacky and less  
thought part, yet:

  static libvlc_media_list_path_t
-get_next_path(libvlc_media_list_player_t * p_mlp)
+get_next_path(libvlc_media_list_player_t * p_mlp, bool b_loop)

+static libvlc_media_list_path_t
+get_previous_path(libvlc_media_list_player_t * p_mlp, bool b_loop)

Given the code duplication we do here, do you think there could be  
some kind of factorization done?


More information about the vlc-devel mailing list