[vlc-devel] [PATCH] Media library module for VLC, GSoC 09

Srikanth Raju srikiraju at gmail.com
Sat Aug 29 08:08:44 CEST 2009

I've split the patch.

The first patch contains the changes that are made to the core.
The second patch contains the media library module.

I want to direct attention to the object system.
media_New() uses pf_GetMedia() from the module.
ml_gc_incref() and ml_gc_decref() are implemented in the core.
and the GC is done in watch_loop() in pool_GC() in the module.

This is clearly not good. I was wondering if this functionality needs to be
moved wholly into the core, or to the module. I'm leaning towards
the module.
Also, I was wondering if pool_GC() is safe( that is, there are no issues with
reading the gc internals like that )

We had an issue about vlc_media_library.h being too big. We want to shorten
it. So any feedback along that direction is cool. Again, this goes in
the direction
of where to put which function(core or module).

Srikanth Raju
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Media-library-core.patch
Type: text/x-diff
Size: 70225 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090829/49c80858/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Media-Library-module.patch
Type: text/x-diff
Size: 221032 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090829/49c80858/attachment-0001.patch>

More information about the vlc-devel mailing list