[vlc-devel] commit: contrib: assume TI OMAP3 core when on Maemo/armel ( Rémi Denis-Courmont )

[Måns Rullgård]

git at videolan.org (git version control) writes:

> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Aug 29 18:08:02 2009 +0300| [3c6c622cc37b121faa402414e0a90a79d4aaf370] | committer: Rémi Denis-Courmont 
>
> contrib: assume TI OMAP3 core when on Maemo/armel
>
> This tries to preserve maemo-x86 compatibilty, if anyone cares.
> However, this probably breaks N8x0 support if it ever worked(?).

Yes, it will break N8x0 since they are only ARMv6.

>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3c6c622cc37b121faa402414e0a90a79d4aaf370
> ---
>
>  extras/contrib/bootstrap |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/extras/contrib/bootstrap b/extras/contrib/bootstrap
> index ebce9e7..5e34e46 100755
> --- a/extras/contrib/bootstrap
> +++ b/extras/contrib/bootstrap
> @@ -235,6 +235,15 @@ case $HOST in
>              cat src/Distributions/unix.mak >> distro.mak
>          fi
>      ;;
> +    arm-none-linux-gnueabi)
> +        if test -f /etc/maemo_version; then

Why only for maemo, and not for other ARM systems?

> +            cat src/Distributions/maemo.mak >> distro.mak
> +            echo 'HAVE_MAEMO = 1' >> config.mak
> +            EXTRA_CFLAGS=" -mcpu=cortex-a8 -mtune=cortex-a8 -march=armv7-a"
> +            EXTRA_CLFAGS="$EXTRA_CFLAGS -mfpu=vfp"

That should be -mfpu=neon for cortex-a8, or you'll be missing all the
NEON goodness.

> +            EXTRA_CFLAGS="$EXTRA_CFLAGS -mthumb -mthumb-interwork"
> +        fi
> +    ;;

-- 
Måns Rullgård
mans at mansr.com