[vlc-devel] commit: contrib: turn off Thumb ISA for libavcodec and libmad ( Rémi Denis-Courmont )

[Måns Rullgård]

"Rémi Denis-Courmont" <remi at remlab.net> writes:

> Le samedi 29 août 2009 21:49:27 Måns Rullgård, vous avez écrit :
>> git at videolan.org (git version control) writes:
>> > diff --git a/extras/contrib/src/Patches/ffmpeg-avcodec-no-thumb.patch
>> > b/extras/contrib/src/Patches/ffmpeg-avcodec-no-thumb.patch new file mode
>> > 100644
>> > index 0000000..21b51a5
>> > --- /dev/null
>> > +++ b/extras/contrib/src/Patches/ffmpeg-avcodec-no-thumb.patch
>> > @@ -0,0 +1,10 @@
>> > +Index: ffmpeg/libavcodec/Makefile
>> > +===================================================================
>> > +--- ffmpeg/libavcodec/Makefile	(révision 19635)
>> > ++++ ffmpeg/libavcodec/Makefile	(copie de travail)
>> > +@@ -1,4 +1,5 @@
>> > + include $(SUBDIR)../config.mak
>> > ++CFLAGS+=-mno-thumb
>> > +
>> > + NAME = avcodec
>> > + FFLIBS = avutil
>>
>> This will probably not work properly.  The proper solution is to pass
>> --extra-cflags=-mno-thumb to the FFmpeg configure script.
>
> It did work. At least, it did make the code compile which wouldn't
> work with Thumb. I guess avcodec uses fancy ASM instructions outside
> of Thumb-2.

I believe you if you say it worked, but I still maintain it's not a
reliable method.

-- 
Måns Rullgård
mans at mansr.com