[vlc-devel] commit: record: forgotten initializations (Erwan Tulou )

[Rémi Denis-Courmont]

Le samedi 29 août 2009 23:10:53 git version control, vous avez écrit :
> vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Sat Aug 29
> 22:07:38 2009 +0200| [d932926590aac6d22bc906498461c9c8e3148a24] |
> committer: Erwan Tulou
>
> record: forgotten initializations
>
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d932926590aac6d22b
> >c906498461c9c8e3148a24
>
> ---
>
>  modules/stream_out/record.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/modules/stream_out/record.c b/modules/stream_out/record.c
> index 44cf424..c641686 100644
> --- a/modules/stream_out/record.c
> +++ b/modules/stream_out/record.c
> @@ -306,8 +306,8 @@ static int OutputNew( sout_stream_t *p_stream,
>                        const char *psz_muxer, const char *psz_prefix, const
> char *psz_extension  ) {
>      sout_stream_sys_t *p_sys = p_stream->p_sys;
> -    char *psz_file;
> -    char *psz_output;
> +    char *psz_file = NULL;
> +    char *psz_output = NULL;
>      int i_count;
>
>      if( asprintf( &psz_file, "%s%s%s",

This is incorrect. If asprintf() fails *psz_file is undefined, not untouched.

-- 
Rémi Denis-Courmont
http://www.remlab.net/