[vlc-devel] commit: variables: print a warning if the callback isn' t found or if a close callback ( Rémi Duraffort )

Rémi Denis-Courmont remi at remlab.net
Mon Aug 31 09:28:51 CEST 2009




On Mon, 31 Aug 2009 09:02:39 +0200, Rémi Duraffort <ivoire at videolan.org>
wrote:
>>> variables: print a warning if the callback isn't found or if a close  
>>> callback
>>> is found (same function but not same data).
>>> This can be usefull to find some errors.
>>
>> I would probably assert here.
> 
> I don't know because you can have some valid code that generate such
> warnings (valid IMHO) like the Qt4 intf.

We should assert that a matching registration was found.
Of course, the same function might be registered multiple times, with
identical or different opaque pointers. But nobody should ever try to
delete a callback that was not registered.

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list