[vlc-devel] commit: file access: only use linux/magic.h when it's present ( Rafaël Carré )

Rafaël Carré rafael.carre at gmail.com
Mon Aug 31 17:35:49 CEST 2009

On Mon, 31 Aug 2009 18:30:21 +0300
"Rémi Denis-Courmont" <remi at remlab.net> wrote:

> Le lundi 31 août 2009 18:27:48 Rafaël Carré, vous avez écrit :
> > On Mon, 31 Aug 2009 18:24:50 +0300
> >
> > "Rémi Denis-Courmont" <remi at remlab.net> wrote:
> > > only the kernel headers need to be updated (not the _running_
> > > kernel).
> >
> > that means f_type member was present in older kernels but the magic
> > values were not advertised?
> They are scattered in all kind of files or hidden, yes. You really
> just need to copy the linux/magic.h from a non-ancient kernel into
> your include path.

You're right I just checked.

I believe we should just put a warning in configure and/or file.c if
the headers are not up to date, but I won't protest if you think it
must be made an error.

I'm too lazy to update the kernel headers since i don't care about
nfs/smb :o

Rafaël Carré
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20090831/2bce5482/attachment.sig>

More information about the vlc-devel mailing list