[vlc-devel] commit: Input item type cannot be negative (fix warning) ( Rémi Denis-Courmont )

git version control git at videolan.org
Sat Dec 5 11:59:26 CET 2009


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Dec  5 12:51:19 2009 +0200| [1a8b0cfea4dc9db9ef13325012a0b9f017c38c0b] | committer: Rémi Denis-Courmont 

Input item type cannot be negative (fix warning)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=1a8b0cfea4dc9db9ef13325012a0b9f017c38c0b
---

 .../gui/qt4/components/playlist/playlist_model.cpp |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/modules/gui/qt4/components/playlist/playlist_model.cpp b/modules/gui/qt4/components/playlist/playlist_model.cpp
index 3d0e6f1..fe586d9 100644
--- a/modules/gui/qt4/components/playlist/playlist_model.cpp
+++ b/modules/gui/qt4/components/playlist/playlist_model.cpp
@@ -336,9 +336,8 @@ QVariant PLModel::data( const QModelIndex &index, int role ) const
     }
     else if( role == Qt::DecorationRole && index.column() == 0  )
     {
-        /* Use to segfault here because i_type wasn't always initialized */
-        if( item->p_input->i_type >= 0 )
-            return QVariant( PLModel::icons[item->p_input->i_type] );
+        /* Used to segfault here because i_type wasn't always initialized */
+        return QVariant( PLModel::icons[item->p_input->i_type] );
     }
     else if( role == Qt::FontRole )
     {




More information about the vlc-devel mailing list