[vlc-devel] commit: Skins2: Cosmetic. (JP Dinger )

[git version control]

vlc | branch: master | JP Dinger <jpd at videolan.org> | Sat Nov 21 21:19:28 2009 +0100| [1bb2388c5dc158d4da460307f4ad4d71e9f35a18] | committer: JP Dinger 

Skins2: Cosmetic.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=1bb2388c5dc158d4da460307f4ad4d71e9f35a18
---

 modules/gui/skins2/controls/ctrl_image.cpp        |    4 ++--
 modules/gui/skins2/controls/ctrl_radialslider.cpp |    2 +-
 modules/gui/skins2/controls/ctrl_slider.cpp       |    6 +++---
 modules/gui/skins2/src/skin_common.hpp            |   12 ------------
 modules/gui/skins2/src/tooltip.cpp                |    4 ++--
 modules/gui/skins2/win32/win32_window.cpp         |   14 ++------------
 6 files changed, 10 insertions(+), 32 deletions(-)

diff --git a/modules/gui/skins2/controls/ctrl_image.cpp b/modules/gui/skins2/controls/ctrl_image.cpp
index 18bc2af..854fab6 100644
--- a/modules/gui/skins2/controls/ctrl_image.cpp
+++ b/modules/gui/skins2/controls/ctrl_image.cpp
@@ -47,7 +47,7 @@ CtrlImage::CtrlImage( intf_thread_t *pIntf, const GenericBitmap &rBitmap,
 
 CtrlImage::~CtrlImage()
 {
-    SKINS_DELETE( m_pImage );
+    delete m_pImage;
 }
 
 
@@ -108,7 +108,7 @@ void CtrlImage::draw( OSGraphics &rImage, int xDest, int yDest )
                     OSFactory *pOsFactory = OSFactory::instance( getIntf() );
                     // Rescale the image with the actual size of the control
                     ScaledBitmap bmp( getIntf(), m_rBitmap, width, height );
-                    SKINS_DELETE( m_pImage );
+                    delete m_pImage;
                     m_pImage = pOsFactory->createOSGraphics( width, height );
                     m_pImage->drawBitmap( bmp, 0, 0 );
                 }
diff --git a/modules/gui/skins2/controls/ctrl_radialslider.cpp b/modules/gui/skins2/controls/ctrl_radialslider.cpp
index b12a51d..de0eeec 100644
--- a/modules/gui/skins2/controls/ctrl_radialslider.cpp
+++ b/modules/gui/skins2/controls/ctrl_radialslider.cpp
@@ -72,7 +72,7 @@ CtrlRadialSlider::CtrlRadialSlider( intf_thread_t *pIntf,
 CtrlRadialSlider::~CtrlRadialSlider()
 {
     m_rVariable.delObserver( this );
-    SKINS_DELETE( m_pImgSeq );
+    delete m_pImgSeq;
 }
 
 
diff --git a/modules/gui/skins2/controls/ctrl_slider.cpp b/modules/gui/skins2/controls/ctrl_slider.cpp
index b7c9829..6b1883b 100644
--- a/modules/gui/skins2/controls/ctrl_slider.cpp
+++ b/modules/gui/skins2/controls/ctrl_slider.cpp
@@ -99,9 +99,9 @@ CtrlSliderCursor::CtrlSliderCursor( intf_thread_t *pIntf,
 CtrlSliderCursor::~CtrlSliderCursor()
 {
     m_rVariable.delObserver( this );
-    SKINS_DELETE( m_pImgUp );
-    SKINS_DELETE( m_pImgDown );
-    SKINS_DELETE( m_pImgOver );
+    delete m_pImgUp;
+    delete m_pImgDown;
+    delete m_pImgOver;
 }
 
 
diff --git a/modules/gui/skins2/src/skin_common.hpp b/modules/gui/skins2/src/skin_common.hpp
index 9c92e44..a8030b0 100644
--- a/modules/gui/skins2/src/skin_common.hpp
+++ b/modules/gui/skins2/src/skin_common.hpp
@@ -59,18 +59,6 @@ class ThemeRepository;
 #pragma warning ( disable:4786 )
 #endif
 
-// Useful macros
-#define SKINS_DELETE( p ) \
-   if( p ) \
-   { \
-       delete p; \
-   } \
-   else \
-   { \
-       msg_Err( getIntf(), "delete NULL pointer in %s at line %d", \
-                __FILE__, __LINE__ ); \
-   }
-
 
 /// Wrapper around FromLocale, to avoid the need to call LocaleFree()
 static inline string sFromLocale( const string &rLocale )
diff --git a/modules/gui/skins2/src/tooltip.cpp b/modules/gui/skins2/src/tooltip.cpp
index a0798b8..644ef79 100644
--- a/modules/gui/skins2/src/tooltip.cpp
+++ b/modules/gui/skins2/src/tooltip.cpp
@@ -49,8 +49,8 @@ Tooltip::Tooltip( intf_thread_t *pIntf, const GenericFont &rFont, int delay ):
 Tooltip::~Tooltip()
 {
     VarManager::instance( getIntf() )->getTooltipText().delObserver( this );
-    SKINS_DELETE( m_pTimer );
-    SKINS_DELETE( m_pOsTooltip );
+    delete m_pTimer;
+    delete m_pOsTooltip;
     delete m_pImage;
 }
 
diff --git a/modules/gui/skins2/win32/win32_window.cpp b/modules/gui/skins2/win32/win32_window.cpp
index f0fff07..7102f96 100644
--- a/modules/gui/skins2/win32/win32_window.cpp
+++ b/modules/gui/skins2/win32/win32_window.cpp
@@ -193,18 +193,8 @@ void Win32Window::setOpacity( uint8_t value ) const
 
 void Win32Window::toggleOnTop( bool onTop ) const
 {
-    if( onTop )
-    {
-        // Set the window on top
-        SetWindowPos( m_hWnd, HWND_TOPMOST, 0, 0, 0, 0,
-                      SWP_NOSIZE | SWP_NOMOVE );
-    }
-    else
-    {
-        // Set the window not on top
-        SetWindowPos( m_hWnd, HWND_NOTOPMOST, 0, 0, 0, 0,
-                      SWP_NOSIZE | SWP_NOMOVE );
-    }
+    SetWindowPos( m_hWnd, onTop ? HWND_TOPMOST : HWND_NOTOPMOST,
+                  0, 0, 0, 0, SWP_NOSIZE | SWP_NOMOVE );
 }