[vlc-devel] commit: SDP: don't disallow RTCP RR (Pierre Ynard )

git version control git at videolan.org
Mon Dec 7 19:00:10 CET 2009


vlc | branch: master | Pierre Ynard <linkfanel at yahoo.fr> | Mon Dec  7 18:51:29 2009 +0100| [b377e1af8d5a0df8e9969655a2024b251724c83c] | committer: Pierre Ynard 

SDP: don't disallow RTCP RR

It does more harm than good, since some clients (RealPlayer) will
just throw out a "not enough bandwidth" error and fail to open the
stream.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b377e1af8d5a0df8e9969655a2024b251724c83c
---

 src/stream_output/sdp.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/src/stream_output/sdp.c b/src/stream_output/sdp.c
index d2c0610..47bb16f 100644
--- a/src/stream_output/sdp.c
+++ b/src/stream_output/sdp.c
@@ -225,8 +225,7 @@ char *sdp_AddMedia (char **sdp,
 
     outlen += snprintf (NULL, 0,
                         "m=%s %u %s %d\r\n"
-                        "b=TIAS:%u\r\n"
-                        "b=RR:0\r\n",
+                        "b=TIAS:%u\r\n",
                         type, dport, protocol, pt, bw);
 
     newsdp = realloc (*sdp, outlen + 1);
@@ -240,7 +239,6 @@ char *sdp_AddMedia (char **sdp,
                          type, dport, protocol, pt);
     if (bw > 0)
         ptr += sprintf (ptr, "b=%s:%u\r\n", bw_indep ? "TIAS" : "AS", bw);
-    ptr += sprintf (ptr, "b=RR:0\r\n");
 
     /* RTP payload type map */
     if (ptname != NULL)




More information about the vlc-devel mailing list