[vlc-devel] commit: Skins2: Replace some theme macros by templated code. (JP Dinger )

[Dominique Leuenberger]

On Sat, 2009-12-05 at 22:35 +0100, git version control wrote:
> vlc | branch: master | JP Dinger <jpd at videolan.org> | Sat Nov 21 19:26:22 2009 +0100| [354811a1209fd23699749daf8ca3b3e68d45b061] | committer: JP Dinger 
> 
> Skins2: Replace some theme macros by templated code.
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=354811a1209fd23699749daf8ca3b3e68d45b061

> -CtrlGeneric *Theme::getControlById( const string &id ) const
> +GenericBitmap *Theme::getBitmapById( const string &id ) const
>  {
> -    FIND_OBJECT( CtrlGenericPtr, m_controls );
> +    m_bitmaps.find_first_object( id );
>  }
>  
> -Position *Theme::getPositionById( const string &id ) const
> +GenericFont *Theme::getFontById( const string &id ) const
>  {
> -    FIND_OBJECT( PositionPtr, m_positions );
> +    m_fonts.find_first_object( id );
>  }

Hi,

At least those two functions trigger a warning on openSUSE Build
System's BRP check. The functions do no longer have any return value
(the macro did have return statements).

The BRP check returns with:

I: Program returns random data in a function
E: vlc-beta no-return-in-nonvoid-function src/theme.cpp:198, 193

Best regards,
Dominique