[vlc-devel] commit: skins(Linux) : fix crash with a few skins (e.g Orangeade) and xcb_x11 (Erwan Tulou )

git version control git at videolan.org
Sat Dec 26 23:02:24 CET 2009


vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Thu Dec 24 09:36:37 2009 +0100| [58a785a56ec1f8685c1d546f5ca2d4bccbff286a] | committer: Erwan Tulou 

skins(Linux) : fix crash with a few skins (e.g Orangeade) and xcb_x11

On X11, windows are created with a 1x1 size and updated later on.
In some context, vout_display can catch this 1x1 size before the size is updated.
This results in a crash in swcaler.c which gets a 1x0 size (division by zero)
Changing default to 10x10 solves the problem.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=58a785a56ec1f8685c1d546f5ca2d4bccbff286a
---

 modules/gui/skins2/x11/x11_window.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/gui/skins2/x11/x11_window.cpp b/modules/gui/skins2/x11/x11_window.cpp
index 9b7188f..d450d0d 100644
--- a/modules/gui/skins2/x11/x11_window.cpp
+++ b/modules/gui/skins2/x11/x11_window.cpp
@@ -88,7 +88,7 @@ X11Window::X11Window( intf_thread_t *pIntf, GenericWindow &rWindow,
     }
 
     // Create the window
-    m_wnd = XCreateWindow( XDISPLAY, m_wnd_parent, -10, 0, 1, 1, 0, 0,
+    m_wnd = XCreateWindow( XDISPLAY, m_wnd_parent, -10, 0, 10, 10, 0, 0,
                            InputOutput, CopyFromParent, valuemask, &attr );
 
     // wait for X server to process the previous commands




More information about the vlc-devel mailing list