[vlc-devel] RE : [PATCH] - msw(directx) fullscreen support (new api)

brezhoneg1 brezhoneg1 at yahoo.fr
Sun Dec 27 21:33:00 CET 2009


Hi,

   Please find attached a new patch for review.

> > index f2bbc97..5485185 100644
> > --- a/modules/video_output/msw/common_vo.c
> > +++ b/modules/video_output/msw/common_vo.c
> > @@ -142,7 +142,7 @@ void CommonManage( vout_thread_t *p_vout )  {
> >      /* If we do not control our window, we check for geometry
changes
> >       * ourselves because the parent might not send us its events.
*/
> > -    if( p_vout->p_sys->hparent && !p_vout->b_fullscreen )
> > +    if( p_vout->p_sys->hparent )
>  I don't understand the need here.
> 

I think it is needed (actually, the comment above the code explains
why).
Since fullscreen is no longer this module's responsability, we cannot
but poll
the parent window to see changes in size as we do for a normal window.
We are not even sure the vout window provider is managing a single
fullscreen screen.
Maybe, the fullscreen size may vary over time.

btw, does common.c work in fullscreen mode, since the same problem
exists ?
I don't see any place where the new size is detected in fullscreen mode.


> +        {
> > +            Win32ToggleFullscreen( p_vout );
> > +        }
>  I think it would be better to modify Win32ToggleFullscreen() 
> directly as it is called more than once (as alreay done by in 
> new common.c), no ?


You're right. I rewrote it with common.c as example.



Erwan10
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-msw-support-for-vout_window_SetFullscreen.patch
Type: application/octet-stream
Size: 2003 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091227/f87620c6/attachment.obj>


More information about the vlc-devel mailing list