[vlc-devel] [PATCH 3/8] Extensions: core library

[Rémi Denis-Courmont]

Le mercredi 23 décembre 2009, Jean-Philippe André a écrit :
> +    if( !b_ok )
> +        p_mgr->i_num_extensions--; /* Note: leak */

*cough* *cough*

> +/** Wait for an extension to finish */
> +void WaitForDeactivation( extension_t *p_ext )
> +{
> +    void *pointer = NULL;
> +    vlc_cond_signal( &p_ext->p_sys->wait );

This seems dubious without any change of state.

> +    vlc_join( p_ext->p_sys->thread, &pointer );

Why pointer instead of NULL? I think this won't even work on Windows.

-- 
Rémi Denis-Courmont
http://www.remlab.net/