[vlc-devel] [PATCH] Media library core

Srikanth Raju srikiraju at gmail.com
Mon Dec 28 00:00:13 CET 2009


Hello,
I've attached new patches. I've split up the patch into two pieces. The
first is just the vlc_media_library.h header file. The second includes the
core.

Things that need looking into:
* The general API in the header file. Most of the functions are simple
helpers, so it's not really important to look at the implementation in too
much detail. What I'm looking for is a holistic review.
* ml_gc_incref and ml_gc_decref. These rely on a garbage collecting loop in
the module that tests if refs = 1 and then releases the object if so. Is
testing the refs "ok" by anything other than the vlc_gc functions?

Thank you.
-- 
Regards,
Srikanth Raju
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091228/64ef7437/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Include-Media-Library-Headers.patch
Type: text/x-patch
Size: 51233 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091228/64ef7437/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Media-library-core-changes.patch
Type: text/x-patch
Size: 19626 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20091228/64ef7437/attachment-0001.bin>


More information about the vlc-devel mailing list