[vlc-devel] commit: skins2: setOpacity moved to a better place (Erwan Tulou )

git version control git at videolan.org
Mon Dec 28 22:19:13 CET 2009


vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Mon Dec 28 21:33:29 2009 +0100| [858898544a6884b4cc6413a4cf934fb59a9e524d] | committer: Erwan Tulou 

skins2: setOpacity moved to a better place

Opacity used to work only on newly loaded skins, but failed to work from
skins restored from a previous session.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=858898544a6884b4cc6413a4cf934fb59a9e524d
---

 modules/gui/skins2/src/window_manager.cpp |    1 -
 modules/gui/skins2/src/window_manager.hpp |    3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/gui/skins2/src/window_manager.cpp b/modules/gui/skins2/src/window_manager.cpp
index 00dcf71..ed01b06 100644
--- a/modules/gui/skins2/src/window_manager.cpp
+++ b/modules/gui/skins2/src/window_manager.cpp
@@ -425,7 +425,6 @@ void WindowManager::showAll( bool firstTime ) const
         {
             (*it)->show();
         }
-        (*it)->setOpacity( m_alpha );
     }
 }
 
diff --git a/modules/gui/skins2/src/window_manager.hpp b/modules/gui/skins2/src/window_manager.hpp
index 4849f55..6a689f1 100644
--- a/modules/gui/skins2/src/window_manager.hpp
+++ b/modules/gui/skins2/src/window_manager.hpp
@@ -120,7 +120,8 @@ public:
     void raise( TopWindow &rWindow ) const { rWindow.raise(); }
 
     /// Show the given window
-    void show( TopWindow &rWindow ) const { rWindow.show(); }
+    void show( TopWindow &rWindow ) const
+        { rWindow.show(); rWindow.setOpacity( m_alpha); }
 
     /// Hide the given window
     void hide( TopWindow &rWindow ) const { rWindow.hide(); }




More information about the vlc-devel mailing list