[vlc-devel] commit: VCDX: use after free ( Rémi Denis-Courmont )

[git version control]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Dec 30 20:21:07 2009 +0200| [4c56bbfee294e7852846c62719ddf917e1dd57c1] | committer: Rémi Denis-Courmont 

VCDX: use after free

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4c56bbfee294e7852846c62719ddf917e1dd57c1
---

 modules/access/vcdx/info.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/access/vcdx/info.c b/modules/access/vcdx/info.c
index 5c77655..e492fe7 100644
--- a/modules/access/vcdx/info.c
+++ b/modules/access/vcdx/info.c
@@ -312,9 +312,9 @@ VCDUpdateTitle( access_t *p_access )
         char *psz_tfmt = config_GetPsz( p_access, MODULE_STRING "-title-format" );
         snprintf( psz_mrl, psz_mrl_max, "%s%s",
                   VCD_MRL_PREFIX, p_vcdplayer->psz_source );
-        free(psz_tfmt);
         psz_name = VCDFormatStr( p_vcdplayer, psz_tfmt, psz_mrl,
                                  &(p_vcdplayer->play_item) );
+        free(psz_tfmt);
         free(psz_mrl);
         input_Control( p_vcdplayer->p_input, INPUT_SET_NAME, psz_name );
         free(psz_name);