[vlc-devel] commit: Interaction: logically dead code ( Rémi Denis-Courmont )

git version control git at videolan.org
Sun Feb 1 12:01:50 CET 2009


vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Sun Feb  1 13:01:35 2009 +0200| [6b8d2191f4d3885d654e06d2f72818b5083b2f4c] | committer: Rémi Denis-Courmont 

Interaction: logically dead code

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6b8d2191f4d3885d654e06d2f72818b5083b2f4c
---

 src/interface/interaction.c |   18 ++----------------
 1 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/src/interface/interaction.c b/src/interface/interaction.c
index f041878..93381dd 100644
--- a/src/interface/interaction.c
+++ b/src/interface/interaction.c
@@ -502,29 +502,15 @@ static int DialogSend( vlc_object_t *p_this, interaction_dialog_t *p_dialog )
         p_dialog->i_flags & DIALOG_BLOCKING_ERROR ||
         p_dialog->i_flags & DIALOG_NONBLOCKING_ERROR )
     {
-        bool b_found = false;
-        int i;
         p_dialog->p_interaction = p_interaction;
         p_dialog->p_parent = p_this;
 
         /* Check if we have already added this dialog */
         vlc_object_lock( p_interaction );
-        for( i = 0 ; i< p_interaction->i_dialogs; i++ )
-        {
-            if( p_interaction->pp_dialogs[i] == p_dialog )
-                b_found = true;
-        }
         /* Add it to the queue, the main loop will send the orders to the
          * interface */
-        if( ! b_found )
-        {
-            INSERT_ELEM( p_interaction->pp_dialogs,
-                         p_interaction->i_dialogs,
-                         p_interaction->i_dialogs,
-                         p_dialog );
-        }
-        else
-            p_dialog->i_status = UPDATED_DIALOG;
+        INSERT_ELEM( p_interaction->pp_dialogs, p_interaction->i_dialogs,
+                     p_interaction->i_dialogs,  p_dialog );
 
         if( p_dialog->i_type == INTERACT_DIALOG_TWOWAY ) /* Wait for answer */
         {




More information about the vlc-devel mailing list