[vlc-devel] RE : [PATCH] -- fullscreen enhancements

[brezhoneg1]

> Objet : Re: [vlc-devel] [PATCH] -- fullscreen enhancements
> 
> On Fri, Jan 30, 2009 at 07:43:13PM +0100, brezhoneg1 wrote :
> > The first family of patches (patches 1 to 6) implements resizing
video
> > within fullscreen.
> 
> Mostly applied with a few changes.
> 
> > It features the following hotkeys :
> >    - 'o'              : toggle "video scaled to fullscreen" and
> > "original video"
> >    - Shift-alt-'o' : enlarging video
> >    - ctrl-alt-'o ' : shrinking video
> Keys have changed a bit.


No problem. Thanks for your time spent on this issue.

> 
> > The second patch (patch 7) corrects transition issues (vout reuse)
> > especially in fullscreen mode.
> I really don't feel at ease with that one. Don't ask me to apply it.
> 

This patch was originally aimed at proving width/height restrictions
should not be seen as a big problem. This patch can certainly be
improved. Ideally, setting (the first time) and resetting (when reusing
vout) should be mutualized. Yet, it is a working patch, and hopefully I
have not made wrong assumptions.

My point is:
- vlc1.0 will be a landmark in vlc history. 
- vlc1.0 has raised expectations that the transition problems will be
solved (see numerous posts and answers on the forum)

For the sake of vlc, I really think working out this height/width
limitation would avoid users complaining bitterly for what can honestly
be considered a bug. (With vlc1.0, this will even be more annoying that
users don't have in mind this limitation and will see it as an erratic
behavior)

Maybe, if someone with good knowledge of vout could react to it (fenrir,
from what I was said ?).

Erwan10