[vlc-devel] RE : [PATCH] -- fullscreen enhancements

[Laurent Aimar]

Hi,
On Mon, Feb 02, 2009, brezhoneg1 wrote:
> > > The second patch (patch 7) corrects transition issues (vout reuse)
> > > especially in fullscreen mode.
> > I really don't feel at ease with that one. Don't ask me to apply it.
> > 
> 
> This patch was originally aimed at proving width/height restrictions
> should not be seen as a big problem. This patch can certainly be
> improved. Ideally, setting (the first time) and resetting (when reusing
> vout) should be mutualized. Yet, it is a working patch, and hopefully I
> have not made wrong assumptions.
> 
> My point is:
> - vlc1.0 will be a landmark in vlc history. 
> - vlc1.0 has raised expectations that the transition problems will be
> solved (see numerous posts and answers on the forum)
> 
> For the sake of vlc, I really think working out this height/width
> limitation would avoid users complaining bitterly for what can honestly
> be considered a bug. (With vlc1.0, this will even be more annoying that
> users don't have in mind this limitation and will see it as an erratic
> behavior)
 I do agree that this functionnality/fix is really welcome, and I thank you
for your patch.

> Maybe, if someone with good knowledge of vout could react to it (fenrir,
> from what I was said ?).
 The only problem is that I do not feel confident enough on the vout part
to be sure it won't create any problem.
 If we were not about to issue the 1.0 release I would have applied it.
 But for 1.0 I think it is safer to not use it (or at least I cannot say
if applying it is safe), so yes it will be a bit less user friendly but I
prefer to avoid regression.

 As soon as 1.0 is released (and in its own branch) I will apply this patch
(bug me if I don't) and if tested stable it could (if agreed) make it to 1.0
stabilization branch later on.

Regards,

-- 
fenrir