[vlc-devel] commit: mozilla: call libvlc_playlist_items_count() with playlist lock held . (Jean-Paul Saman )

[Rémi Denis-Courmont]

Le lundi 9 février 2009 17:47:45 Jean-Paul Saman, vous avez écrit :
> Jean-Baptiste Kempf wrote:
> > On Mon, Feb 09, 2009 at 09:45:24AM +0100, git version control wrote :
> >> vlc | branch: master | Jean-Paul Saman <jean-paul.saman at m2x.nl> | Mon
> >> Feb  9 09:42:07 2009 +0100| [b9dfd94693317fec3df66bd418b90777db8b8a93] |
> >> committer: Jean-Paul Saman
> >>
> >> mozilla: call libvlc_playlist_items_count() with playlist lock held.
> >
> > Should this be backported ?
>
> It protects playlist_CurrentSize() with a lock. 1.0-git enforces it
> 0.9-bugfix doesn't. I think it is safe to backport this, but do test
> when you do.

What's the point of taking the lock if you do nothing but read the value 
before you release? It's not going to be much "safer". I don't see the point 
of backporting.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary