[vlc-devel] [PATCH] ZIP Module - Use the system minizip when available

[Rémi Denis-Courmont]

Le mercredi 11 février 2009 11:46:53 Nicolas Chauvet (kwizart), vous avez 
écrit :
> - Ship the vlc module header zip.h
>  (rename isn't needed once the file in ship)
> - Detect minizip presence with pkgconfig
> - if .pc not available, try to assume presence from unzip.h
> - Move the zlib.h detection in one place (after pkgconfig macro)
>  minizip in bundled within zlib in some distro
> - Adds -lz in module that needs it in one place
> - Prevent the compilation of libs/unzip if minizip is available
>  (it shound't prevent this directory to be bundled with the sources)

This looks good, and I'll merge it, but... why do we duplicate minizip then?

If it is a proper third party library, it should go to contrib, not to libs...

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary