[vlc-devel] [PATCH] FIX: Dshow "none" device open (#2201). Some cleaning
noxelia at gmail.com
Thu Feb 12 15:05:46 CET 2009
2009/2/11 Rémi Denis-Courmont <rem at videolan.org>:
> Le mercredi 11 février 2009 16:15:48 basos g, vous avez écrit :
>> These 2 patches address the issue in dshow as well as some other fixes
>> -Fix dshow "none" deivice be recognized as none
>> Note that another patch concerning var_optionParse string
>> dequoting should be applied for this to be fixed
>> ( the concept is not to provide quoted strings to dshow options )
>> -Account for the case when BOTH devices could not be opened
>> (file an error, instead of seeming to play)
>> -Cleaned a little
>> -Added dbg and error msgs
>> -Added coments
> I am not against removing quotes there, but we have to be consistent.
> Discarding quotes is wrong. There has to be a way to pass a value that does
> include quotes.
> Rémi Denis-Courmont
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
The point is that for the dshow we don't need quotes.
Do we need them elsewhere ?
I think quotes mean: take the hole following string including spaces.
As long as the delimiting is done correctly i am not sure that we
actualy need the quotes inside psz_data.
:adev="Create sound blaster" :vdev="vid1" :type=pal etc
here psz_value for adev should be
Creative sound blaster
"Creative sound blaster"
More information about the vlc-devel