[vlc-devel] [PATCH] -- autoscale/scalefactor issues

[Jean-Baptiste Kempf]

On Fri, Feb 13, 2009 at 02:25:32PM +0100, brezhoneg1 wrote :
> After some more tests on Linux and Windows, this patch corrects the
> following issues :
> 
> 1- A Windows specific limitation.
> 
> On Windows (tested with vlc1.0-git-20060211 from jb's website), the
I think you meant 20090211 :D

> 'Alt-o' hotkey leads to a black screen when zooming exceeds the
> container size. This patch makes sure we don't exceed this container
> size.
Yes. I noticed that two. Thanks for fixing.

> 2 - Original width/height calculation
> 
> When an original video doesn't have square pixel (sar != 1:1), original
> width and height is not straightforward. You need to choose one
> direction as a reference and either scale up or down the other
> direction. 
> 
> In vlc, scaling up was done in InitWindowSize and scaling down was done
> in Vout_PlacePicture (but never used before autoscale was introduced )
> This patch changes Vout_PicturePlace to also scale up as InitWindowSize
> does.

> 3- small cosmetic change about i_zoom

Can you separate patches, please? That helps a lot for regression
tracking.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/