[vlc-devel] commit: QT4: connect signal from inputmanager metaChanged to playlist-model so it updates item . (Ilkka Ollakka )

[Laurent Aimar]

Hi,

On Sun, Feb 15, 2009, git version control wrote:
> QT4: connect signal from inputmanager metaChanged to playlist-model so it updates item.
> input: send inputEvent when length if input changes
> 
> diff --git a/src/input/event.c b/src/input/event.c
> index 9224478..9fde713 100644
> --- a/src/input/event.c
> +++ b/src/input/event.c
> @@ -69,9 +69,12 @@ void input_SendEventTimes( input_thread_t *p_input,
>      val.i_time = i_time;
>      var_Change( p_input, "time", VLC_VAR_SETVALUE, &val, NULL );
>  
> -	/* FIXME ugly + what about meta change event ? */
> +    /* FIXME ugly */
>      if( var_GetTime( p_input, "length" ) != i_length )
> +    {
>          input_item_SetDuration( p_input->p->p_item, i_length );
> +        input_SendEventMeta( p_input );
> +    }
 Could your revert at least this part ?

 input_item_SetDuration already emit a vlc_InputItemDurationChanged on duration
changes.
 The playlist will then emit the id of this item in "item-change".
 The Qt4 interface has a callback on ItemChanged which will post ItemChanged_Type.

 So if it does not work, it's a Qt4 specific problem about ItemChanged_Type that need
fixing, not a workaround in input core.

Regards,

-- 
fenrir