[vlc-devel] [PATCH] file extension manager (fixed patch)

[Rémi Denis-Courmont]

On Fri, 20 Feb 2009 00:20:24 +0100, ßєŋ <sashipa.ben at gmail.com> wrote:
> extern won't link against C++. ... As far as VLC core is in C I agree
with
> you.

The core _is_ in C. In fact, those declarations should be in a private
header inside src/ rather than include/

>> Using asprintf() (or QString) would be simpler and less likely to break
>> if someone changes the code later.
>>
> 
> I don't know anything about Qstuff; never used and never wanted to.
> asprintf is a convenient GNU extension.

Nope. VLC does provide asprintf() on non-GNU systems.

> Totally useless in that context. I'm copying exclusively file
> extension that are never longer than
> a few chars. size_t looks like  a waste too me.

On 32-bits system, it won't make a difference. On 64-bits, they will both
spend on register anyway.

>> With the public API, we may have multiple instances in the same process.
>> I am afraid this is not thread-safe.
>>
> 
> Process or thread ?

We can have multiple instances in a single process, in the same or in
different thread.

-- 
Rémi Denis-Courmont