[vlc-devel] RE : RE : RE : [PATCH] - issue with mouse-x/mouse-y onLinux

[brezhoneg1]

> 
> On Fri, 20 Feb 2009 14:29:40 +0100, "brezhoneg1" <brezhoneg1 at yahoo.fr>
> wrote:
> > This patch just corrects a (small but real) bug ! It's no big deal
and
> > the blame should not be put on the vout architecture in that matter.
> 
> It is a problem with the architecture, unless I missed the answer to
my
> earlier points about deinterlace, rotate and such.
> 
> The only solution is to translate the mouse events in the filters
> themselves.

Okay, I think I get what you mean.

In today's formula, mouse-x/mouse-y pinpoint the coordinates in the
original picture in most-but-not-all cases. 

What if the picture has been rotated? I agree an extra translation has
to occur at the filter level to correct this filtering effect. 

So yes, there is a vout design issue here.

But, that should not prevent from correcting a bug that has nothing to
do with this design issue.

Whatever the formula (and it can be challenged), let's make sure the
resulting range of value is not truncated in an unfortunate way (nothing
to do with a rationale, just a developer forgetting to update those
boundary tests). At least, code will be more understandable and a bug is
corrected.

Erwan10