[vlc-devel] commit: mozilla: video is displayed again(Jean-Paul Saman )

Rémi Denis-Courmont rem at videolan.org
Fri Feb 20 16:34:38 CET 2009


Le vendredi 20 février 2009 16:36:57 jean-paul.saman at planet.nl, vous avez 
écrit :
> According to our IRC conversation drawable and drawable-xid are
> semantically the same. The point of courmisch commit on this subject was
> that all parent windows handlers are specific to a platform and that they
> should no use the same event. Is this correct courmisch?

My point was that some platforms may support more than one type of windows. 
X11 output may work on Windows (since Xlib supports Win32) and OSX. And with 
a little bit of work, the MSW output could be handled through libwine (the 
DirectX output _almost_ compiles on Linux). So this commit is wrong.

Worse, it assumes sizeof(int)>=sizeof(void *) which is NOT true on 64-bits 
OSX. Instead a separate drawable-agl should be added on OSX, as far as AGL 
really is OSX specific.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary



More information about the vlc-devel mailing list