[vlc-devel] commit: Cosmetics. (Laurent Aimar )

Rémi Denis-Courmont rdenis at simphalempin.com
Wed Feb 25 08:44:43 CET 2009


On Tue, 24 Feb 2009 23:44:56 +0100 (CET), git at videolan.org (git version
control) wrote:
> -            *pp_sectors = malloc( (i_tracks + 1) * sizeof(int) );
> +            *pp_sectors = malloc( (i_tracks + 1) * sizeof(**pp_sectors)
> );
>              if( *pp_sectors == NULL )
>                  return 0;
>              memcpy( *pp_sectors, p_vcddev->p_sectors,
> -                    (i_tracks + 1) * sizeof(int) );
> +                    (i_tracks + 1) * sizeof(**pp_sectors) );

How big can i_tracks be, and can we read it from a disk image? It looks
like an integer overflow, but then again not if i_tracks is 16 bits.

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list